You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you, this is awesome to see! If you don't mind, I'd rather leave the README as-is and instead create a new CommonPatterns.md doc with these common patterns. The README can link to these Common Patterns instead. I'd like to keep the README focused as documentation for the API and have Common Patterns just act as example code.
@tizmagik Sorry to reply so late.
Of course you can! my last suggestion is that readme needs upgrade. For exmaple, remove es5 example code because es6 is so popular today. If a developer can use decorator, he must understand usage of arrow function. Focus on core things and explain dispatchOnMountprocess these apis later.
Thanks for your great work. I learned a lot after reading source code. If anything i can help, just tell me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linked to #86 #109
Improvement:
Common patternssection in Readme and introduce track work as decorator or HOC.Advanced Usagesection toCommon patternsfor users could understand at first glance through example code.Help want:
My english is really poor as a chinese , so it is much grateful if you could check gramma error.